Repository navigation
CURA-13374 Fix translations context/place - #1064
Merged
Merged
Conversation
CURA-13374 The "From Disk" label is no more in Uranium but in Cura, and some contexts have changed.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped removal is consistent across the template and locale catalogs, with no remaining consumers or unresolved issues identified.
No open issues 🎉
What changed in this PR
Removes the obsolete “From Disk” translation entry from Uranium, reflecting that the label now belongs to Cura.
Changes:
- Removes the
@menuentry from the translation template. - Removes the matching entry from all 17 locale catalogs.
| File | Description |
|---|---|
| resources/i18n/zh_TW/uranium.po | Removes the Traditional Chinese entry. |
| resources/i18n/zh_CN/uranium.po | Removes the Simplified Chinese entry. |
| resources/i18n/uranium.pot | Removes the obsolete template entry. |
| resources/i18n/tr_TR/uranium.po | Removes the Turkish entry. |
| resources/i18n/ru_RU/uranium.po | Removes the Russian entry. |
| resources/i18n/pt_PT/uranium.po | Removes the European Portuguese entry. |
| resources/i18n/pt_BR/uranium.po | Removes the Brazilian Portuguese entry. |
| resources/i18n/pl_PL/uranium.po | Removes the untranslated Polish entry. |
| resources/i18n/nl_NL/uranium.po | Removes the Dutch entry. |
| resources/i18n/ko_KR/uranium.po | Removes the Korean entry. |
| resources/i18n/ja_JP/uranium.po | Removes the Japanese entry. |
| resources/i18n/it_IT/uranium.po | Removes the Italian entry. |
| resources/i18n/hu_HU/uranium.po | Removes the untranslated Hungarian entry. |
| resources/i18n/fr_FR/uranium.po | Removes the French entry. |
| resources/i18n/fi_FI/uranium.po | Removes the untranslated Finnish entry. |
| resources/i18n/es_ES/uranium.po | Removes the Spanish entry. |
| resources/i18n/de_DE/uranium.po | Removes the German entry. |
| resources/i18n/cs_CZ/uranium.po | Removes the Czech entry. |
Review effort: Balanced
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "From Disk" label is no more in Uranium but in Cura
Comes with Ultimaker/Cura#21874
CURA-13374